Merged
Conversation
When using tg.c as TG_STATIC, there are two warnings: from a declared function
which isn't implemented and an extra argument in the documentation.
Function with only a prototype (when compiled with `gcc -Wall -Werror`):
tg.c:406:16: warning: 'tg_poly_coveredby_poly' declared 'static' but never defined [-Wunused-function]
406 | TG_EXTERN bool tg_poly_coveredby_poly(const struct tg_poly *a,
| ^~~~~~~~~~~~~~~~~~~~~~
Documentation with an extra argument (when compiled with clang -Wall
-Wdocumentation -Werror):
tg.c:15451:12: warning: parameter 'ix' not found in the function declaration [-Wdocumentation]
15451 | /// @param ix Indexing option, e.g. TG_NONE, TG_NATURAL, TG_YSTRIPES
| ^~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not open a pull request without first filing an issue and/or discussing the feature directly with me.
Please ensure you adhere to every item in this list
Describe your changes
When using tg.c as TG_STATIC, there are two warnings: from a declared function which isn't implemented and an extra argument in the documentation.
Function with only a prototype (when compiled with
gcc -Wall -Werror): tg.c:406:16: warning: 'tg_poly_coveredby_poly' declared 'static' but never defined [-Wunused-function]406 | TG_EXTERN bool tg_poly_coveredby_poly(const struct tg_poly *a,
| ^~~~~~~~~~~~~~~~~~~~~~
Documentation with an extra argument (when compiled with clang -Wall -Wdocumentation -Werror):
tg.c:15451:12: warning: parameter 'ix' not found in the function declaration [-Wdocumentation]
15451 | /// @param ix Indexing option, e.g. TG_NONE, TG_NATURAL, TG_YSTRIPES
| ^~
Issue number and link
See issue #11