Fix YSTRIPES indexing bug for segments at polygon top edge#17
Merged
tidwall merged 1 commit intotidwall:mainfrom Jul 22, 2025
Merged
Fix YSTRIPES indexing bug for segments at polygon top edge#17tidwall merged 1 commit intotidwall:mainfrom
tidwall merged 1 commit intotidwall:mainfrom
Conversation
Owner
|
Excellent PR. Thanks! |
jiayuasu
pushed a commit
to apache/sedona-db
that referenced
this pull request
Aug 29, 2025
This ports a fix submitted to the upstream: tidwall/tg#17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you adhere to every item in this list
Describe your changes
Points touching the top edge of polygons incorrectly return false for intersection tests when using TG_YSTRIPES indexing, while correctly returning true with TG_DEFAULT indexing (see #16 for details). This is caused by a problem in
process_ystripes()when processing horizontal segments at the exact top boundary. The segment will be missed and never intersects with other geometries. This patch fixes this problem by ensuring that the top edge get properly assigned to the highest stripe.Issue number and link
Closes #16.