Updates dependencies and improve CI configuration.#14
Conversation
There was a problem hiding this comment.
Pull request overview
Updates PHP dependencies and streamlines local/CI test execution for the tiny-blocks/docker-container library.
Changes:
- Bump
tiny-blocks/*dependencies andsquizlabs/php_codesnifferversions incomposer.json. - Add a Composer script + Make target to run unit tests without coverage.
- Simplify CI PHP setup by removing explicit
bcmathextension installation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| composer.json | Updates dependency constraints and adds a unit-test-only, no-coverage Composer script. |
| Makefile | Adds a unit-test-no-coverage target and exposes it in the help output. |
| .github/workflows/ci.yml | Removes explicit bcmath extension configuration from setup-php steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @${DOCKER_RUN} composer tests-no-coverage | ||
|
|
||
| .PHONY: unit-test-no-coverage | ||
| unit-test-no-coverage: ## Run unit tests without coverage |
There was a problem hiding this comment.
unit-test-no-coverage runs the container with --network=tiny-blocks, but unlike test / test-no-coverage it does not depend on configure-test-environment. Running this target on a fresh machine will fail if the network (and related volume) hasn’t been created yet; consider adding configure-test-environment as a prerequisite for this target to match the other test targets.
| unit-test-no-coverage: ## Run unit tests without coverage | |
| unit-test-no-coverage: configure-test-environment ## Run unit tests without coverage |
| .PHONY: unit-test-no-coverage | ||
| unit-test-no-coverage: ## Run unit tests without coverage | ||
| @${DOCKER_RUN} composer run unit-tests-no-coverage |
There was a problem hiding this comment.
The Make target is named unit-test-no-coverage, but it invokes the Composer script unit-tests-no-coverage (note the plural). Consider aligning these names (either target or script) to reduce confusion and keep naming consistent with existing test-no-coverage conventions.
| .PHONY: unit-test-no-coverage | |
| unit-test-no-coverage: ## Run unit tests without coverage | |
| @${DOCKER_RUN} composer run unit-tests-no-coverage | |
| .PHONY: unit-tests-no-coverage unit-test-no-coverage | |
| unit-tests-no-coverage: ## Run unit tests without coverage | |
| @${DOCKER_RUN} composer run unit-tests-no-coverage | |
| unit-test-no-coverage: unit-tests-no-coverage |
No description provided.