do not break other boards with the coreboot hacks made for the t480#25
Closed
gaspar-ilom wants to merge 2 commits intotlaurion:poc_t480from
Closed
do not break other boards with the coreboot hacks made for the t480#25gaspar-ilom wants to merge 2 commits intotlaurion:poc_t480from
gaspar-ilom wants to merge 2 commits intotlaurion:poc_t480from
Conversation
46 tasks
…ade Mate Kukri still not fixing things properly but at least it should now be possible to build older thinkpads without regressions. prior, some code was just commented or unreachable. now we make this explicit with preprocessor directives. heads should build all boards on this coreboot version from the same coreboot tree. use CONFIG_BOARD_LENOVO_SKLKBL_THINKPAD_COMMON to decide what to compile this should work for T480, T480S and older thinkpads Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
Merged
Author
|
@tlaurion confirmed working for the T480 per linuxboot#1908 (comment) |
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
Owner
Author
|
Closed as we will test T480 under linuxboot#1908 instead of linuxboot#1906 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is untested. Should be tested by people with external flashers
@tlaurion please merge this into both linuxboot#1908 and linuxboot#1906
EDIT: I decided to use fix it in a way that it would also work with T480S by using
BOARD_LENOVO_SKLKBL_THINKPAD_COMMON