Draft
Conversation
TODO: - how to write a test for this? - what exception is returned? - are we guaranteed to get a reply if the request timeout? - what if the requests is dropped from the queue?
aaronbee
reviewed
Jun 12, 2023
| RequestParam: proto.Bool(true), | ||
| } | ||
|
|
||
| deadline, ok := rpc.Context().Deadline() |
Collaborator
There was a problem hiding this comment.
This isn't going to work for requests sent in multi's, ie. all mutate requests, since a multi's Context() method just returns context.Background().
Maybe you don't care about that case. Just wanted to raise it in case you weren't aware. If you did want it to work for multi's you'd probably have to find the latest Deadline among the requests and use that as your timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: