Fix remainingStreamingBytes timing: set before requestHandler, decrement before dataHandler#1916
Draft
Fix remainingStreamingBytes timing: set before requestHandler, decrement before dataHandler#1916
Conversation
Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix when remainingStreamingBytes is set for GET requests
Fix remainingStreamingBytes set before requestHandler
Mar 13, 2026
Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
Copilot
AI
changed the title
Fix remainingStreamingBytes set before requestHandler
Fix remainingStreamingBytes timing: set before requestHandler, decrement before dataHandler
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maxRemainingBodyLength()relied onremainingStreamingBytesinternally, but the value was set afterrequestHandlerand decremented afterdataHandler, making it meaningless when called from either callback.Changes
remainingStreamingBytesbeforerequestHandler: all three cases (chunked →STATE_IS_CHUNKED, content-length → parsed value, no body → explicit0) are now resolved prior to the request handler being invokedremainingStreamingBytesbeforedataHandler: all four content-length streaming call sites infenceAndConsumePostPaddedandconsumePostPadded(including post-fallback paths) now update the counter first, computefinfrom the pre-decrement value, then invokedataHandlerChunked-encoding paths are unaffected —
ChunkIteratormaintainsremainingStreamingBytesinternally.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.