Open
Conversation
This will allow to use the `Justfile` with both `build.yaml` and `tests.yaml` Signed-off-by: Christophe Fergeau <christophe@fergeau.eu>
I tried using the golang one and was perplexed why `combinations` caused errors. Switching to the python one solved all these problems. Signed-off-by: Christophe Fergeau <christophe@fergeau.eu>
ZMK `build.yaml` files can have a `cmake-args` field to specify additional CMake arguments to use during the build. This commit adds support for that. For readability, cmake-args is not shown in `just list` Signed-off-by: Christophe Fergeau <christophe@fergeau.eu>
With zmk main, the board names are suffixed with a variant such as `adv360pro_left//zmk`. Keeping the `//zmk` in the artifact name causes confusion as it’s a path separator, so the `Justfile` would try to copy the final firmware to `firmware/adv360pro_left//zmk/ while it only created the `firmware` directory. This commit strips everything after the first `/` in the board name when generating the artifact name. Signed-off-by: Christophe Fergeau <christophe@fergeau.eu>
urob
reviewed
Apr 14, 2026
Owner
urob
left a comment
urob
left a comment
There was a problem hiding this comment.
Thanks for taking the time to submit the changes. A few small nitpicking suggestions below, but conceptually that all makes sense!
Author
I’ve added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on a different project (https://github.com/keebs34/zmk-config-selenium), I needed to add a few features to the Justfile I picked from this repo.
Since they are generic, I’m proposing them for inclusion:
listandbuild