fix(turbopack): compitable script external#141
Merged
fireairforce merged 1 commit intoutoofrom Apr 27, 2026
Merged
Conversation
Member
fireairforce
commented
Apr 27, 2026
- script external export compitable with namespace export
- crossorigin compitable with loadScript
There was a problem hiding this comment.
Code Review
This pull request updates project dependencies in Cargo.lock, including the addition of wasmtimer and a switch to a git fork for mimalloc. It also modifies the browser runtime to use a CROSS_ORIGIN constant for script loading and introduces logic in the ECMAScript external module to handle script-type exports by creating a namespace object. Feedback was provided to refine the namespace creation logic by using hasOwnProperty during property iteration and checking for an existing default property before assignment to avoid potential bugs.
xusd320
pushed a commit
that referenced
this pull request
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.