Skip to content

fix(turbopack): compitable script external#141

Merged
fireairforce merged 1 commit intoutoofrom
fix-script-external-load
Apr 27, 2026
Merged

fix(turbopack): compitable script external#141
fireairforce merged 1 commit intoutoofrom
fix-script-external-load

Conversation

@fireairforce
Copy link
Copy Markdown
Member

  • script external export compitable with namespace export
  • crossorigin compitable with loadScript

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates project dependencies in Cargo.lock, including the addition of wasmtimer and a switch to a git fork for mimalloc. It also modifies the browser runtime to use a CROSS_ORIGIN constant for script loading and introduces logic in the ECMAScript external module to handle script-type exports by creating a namespace object. Feedback was provided to refine the namespace creation logic by using hasOwnProperty during property iteration and checking for an existing default property before assignment to avoid potential bugs.

@fireairforce fireairforce merged commit 5383c5d into utoo Apr 27, 2026
11 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant