Fix elevation profile not updating when route changes#372
Open
antburnett wants to merge 4 commits intovalhalla:masterfrom
Open
Fix elevation profile not updating when route changes#372antburnett wants to merge 4 commits intovalhalla:masterfrom
antburnett wants to merge 4 commits intovalhalla:masterfrom
Conversation
The height graph data was only fetched when the drawer was expanded/collapsed. Added a useEffect to automatically fetch height data whenever direction results change.
nilsnolde
requested changes
Mar 13, 2026
Member
nilsnolde
left a comment
nilsnolde
left a comment
There was a problem hiding this comment.
Most of these changes have nothing to do with the PR (I think), and I'm not thrilled of merging them upstream unless there's good reasons (fixing some bug, adding some functionality). You can create your own docker image downstream.
Member
There was a problem hiding this comment.
Oops! I really don't like the checked in .env. Should be a .env.template..
Author
There was a problem hiding this comment.
Yes - there was overreach going on with the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onExpanduseEffectthat automatically fetches height data wheneverdirectionResultschangesJSON.stringifycomparison prevents duplicate/heightAPI callsTest plan
/heightAPI calls when route hasn't changed