fix: Avoid modifying original config in AgentBuilder._build()#509
Open
Lingbo-Huang wants to merge 1 commit intovolcengine:mainfrom
Open
fix: Avoid modifying original config in AgentBuilder._build()#509Lingbo-Huang wants to merge 1 commit intovolcengine:mainfrom
Lingbo-Huang wants to merge 1 commit intovolcengine:mainfrom
Conversation
- Replace pop() operations with dictionary comprehension - Create filtered config dict to avoid side effects - Improve code clarity and maintainability The previous implementation used pop() which modified the original config dict passed to _build(). This could cause issues if the caller retained a reference to the config or wanted to reuse it. The new implementation uses dictionary comprehension to create a new dict excluding 'sub_agents' and 'tools', which are passed explicitly as parameters to avoid conflicts.
Author
|
@cuericlee Hello, this is my first contribute in github. Thank you! |
Author
|
@wangyuelucky hello, It's my first pr, please have a look~ Thank you! |
Author
|
@yaozheng-fang hello~ here, it's my first time to commit pr, please have a look. Thank you |
Collaborator
Got it and we will evaluate this asap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #508
Problem
Currently, the
AgentBuilder._build()method usespop()operations which modify the original config dict, potentially causing:pop()is not clear enoughUse dictionary comprehension to create a new dict, filtering out fields that need to be passed explicitly:
Changes:
Remove agent_config.pop("sub_agents")
Remove agent_config.pop("tools")
Add dictionary filtering to create config_for_init
Add comments explaining the change
Benefits
No side effects: doesn't modify original config
Reusable: config can be used multiple times
Clear intent: code purpose is explicit
Best practice: follows immutability principle