feat[array]: move over to a expr based cast #6404
Open
+1,047
−978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-isaacs
force-pushed
the
ji/remove-cast-compute
branch
from
de59323 to
35717ec
Compare
joseph-isaacs
changed the title
joseph-isaacs
force-pushed
the
ji/remove-cast-compute
branch
from
35717ec to
dbed3f2
Compare
Merging this PR will degrade performance by 11.61%
Performance Changes
Comparing 
Footnotes
|
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
joseph-isaacs
added
the
action/benchmark
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
joseph-isaacs
force-pushed
the
ji/remove-cast-compute
branch
from
0144ee7 to
6290f66
Compare
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
joseph-isaacs
added
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (2)
Powered by Polar Signals Cloud |
Signed-off-by: Joe Isaacs <[email protected]>
Deploying vortex-bench with
|
| Latest commit: |
0fe6999
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://65886161.vortex-93b.pages.dev |
| Branch Preview URL: | https://ji-remove-cast-compute.vortex-93b.pages.dev |
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Signed-off-by: Joe Isaacs <[email protected]>
…pute # Conflicts: # encodings/sparse/src/rules.rs # vortex-array/src/arrays/constant/compute/rules.rs
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Signed-off-by: Joe Isaacs <[email protected]>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #5921
deprecations
compute/cast.rs:95