refactor[array]: move boolean ops to lazy binary expr #6447
+139
−347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Kernel dispatch Signed-off-by: Joe Isaacs <[email protected]> Co-Authored-By: Claude Opus 4.6 <[email protected]>
Merging this PR will degrade performance by 21%
Performance Changes
Comparing 
Footnotes
|
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Signed-off-by: Joe Isaacs <[email protected]>
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (4)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
robert3005
reviewed
Feb 12, 2026
vortex-array/src/compute/boolean.rs
Outdated
| fn is_elementwise(&self) -> bool { | ||
| true | ||
| } | ||
| arrow_boolean(lhs.to_array(), rhs.to_array(), op) |
Contributor
There was a problem hiding this comment.
This should build the binary expression
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Signed-off-by: Joe Isaacs <[email protected]>
joseph-isaacs
added
the
action/benchmark
robert3005
reviewed
Feb 12, 2026
Comment on lines
+222
to
+223
| compute::BooleanOperator::AndKleene => Ok(Operator::And), | ||
| compute::BooleanOperator::OrKleene => Ok(Operator::Or), |
Contributor
There was a problem hiding this comment.
I know this is not part of this pr but do we differentiate between And and AndKleene in the expressions?
Contributor
Author
There was a problem hiding this comment.
All use kleene, I think we can rename and add the others with different enum int values
robert3005
approved these changes
Feb 12, 2026
github-actions
bot
removed
the
action/benchmark
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Signed-off-by: Joe Isaacs <[email protected]>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Author
|
I will fixup between shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR closes an open issue or discussion?
What changes are included in this PR?
Move over boolean compute to lazy expr comptue
What is the rationale for this change?
Want lazy compute for all compute functions, move over boolean here
How is this change tested?
Are there any user-facing changes?
from array/compute/binary deprecated
We will soon deprecate all functions in this mod