Conversation
dependabot
bot
added
dependencies
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5060a7ac5f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "eslint-plugin-prettier": "4.0.0", | ||
| "eslint-plugin-tsdoc": "0.2.14", | ||
| "jest": "29.3.1", | ||
| "jest": "30.3.0", |
There was a problem hiding this comment.
Jest 30 removes alias matcher APIs like toBeCalled* and toThrowError, but this package’s test suite still relies on them (for example packages/calling/src/common/Utils.test.ts and multiple packages/calling/src/Voicemail/*.test.ts assertions). With this version bump, those tests will error at runtime (e.g., expect(...).toBeCalledWith is not a function) until the assertions are renamed to the canonical toHaveBeen* / toThrow matcher names.
Useful? React with 👍 / 👎.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/multi-d4eba38f0e
branch
from
5060a7a to
cc29176
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc29176dc1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "eslint-plugin-prettier": "4.0.0", | ||
| "eslint-plugin-tsdoc": "0.2.14", | ||
| "jest": "27.5.1", | ||
| "jest": "30.3.0", |
There was a problem hiding this comment.
This package is now pinned to Jest 30, but packages/byods/jest.setup.js still implements toBeCalledOnceWith using toBeCalledTimes and toBeCalledWith, which were removed alias matchers in Jest 30; any test using that helper (for example packages/byods/test/unit/spec/http-utils/index.ts) will fail at runtime with missing matcher errors until the extension is rewritten to toHaveBeenCalledTimes/toHaveBeenCalledWith.
Useful? React with 👍 / 👎.
| "eslint-plugin-prettier": "4.0.0", | ||
| "eslint-plugin-tsdoc": "0.2.14", | ||
| "jest": "27.5.1", | ||
| "jest": "30.3.0", |
There was a problem hiding this comment.
Bumping this workspace to Jest 30 will break existing unit assertions that still call removed alias APIs like toBeCalledWith (for example in packages/@webex/contact-center/test/unit/spec/cc.ts and .../services/core/WebexRequest.ts), so these tests will error at execution time until the assertions are migrated to canonical matcher names such as toHaveBeenCalledWith.
Useful? React with 👍 / 👎.
Bumps [jest](https://github.com/jestjs/jest/tree/HEAD/packages/jest) and [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest). These dependencies needed to be updated together. Updates `jest` from 27.5.1 to 30.3.0 - [Release notes](https://github.com/jestjs/jest/releases) - [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/jestjs/jest/commits/v30.3.0/packages/jest) Updates `@types/jest` from 27.4.1 to 30.0.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: jest dependency-version: 30.3.0 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/jest" dependency-version: 30.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/multi-d4eba38f0e
branch
from
cc29176 to
4ef2806
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ef2806dc3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "eslint-plugin-prettier": "4.0.0", | ||
| "eslint-plugin-tsdoc": "0.2.14", | ||
| "jest": "27.5.1", | ||
| "jest": "30.3.0", |
There was a problem hiding this comment.
Bumping this workspace to Jest 30 also breaks packages/byods/test/unit/spec/data-source-client/index.ts because it still asserts with rejects.toThrowError(...). Jest 30 removed alias matcher names (including toThrowError), so this test will now fail at runtime with a missing matcher error even after toBeCalled* aliases are migrated; update this assertion to toThrow(...) to keep the suite runnable.
Useful? React with 👍 / 👎.
|
Dependabot can't resolve your JavaScript dependency files. Because of this, Dependabot cannot update this pull request. |
1 similar comment
|
Dependabot can't resolve your JavaScript dependency files. Because of this, Dependabot cannot update this pull request. |
Bumps jest and @types/jest. These dependencies needed to be updated together.
Updates
jestfrom 27.5.1 to 30.3.0Release notes
Sourced from jest's releases.
... (truncated)
Changelog
Sourced from jest's changelog.
... (truncated)
Commits
efb59c2v30.3.096c53d3feat(jest-config): adddefineConfigandmergeConfigfunctions (#15844)855864ev30.2.0da9b532v30.1.3ebfa31cv30.1.2d347c0fv30.1.14d5f41dv30.1.022236cfv30.0.5f4296d2v30.0.4d4a6c94v30.0.3Updates
@types/jestfrom 27.4.1 to 30.0.0Commits