Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 792a7a468a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| notifType: CC_EVENTS.REAL_TIME_TRANSCRIPTION, | ||
| data: { | ||
| conversationId: taskId, | ||
| messageId: 'msg-merge-1', |
There was a problem hiding this comment.
Use RTD payload shape that TaskManager actually parses
These new RTD transcript tests construct events as {"notifType": ..., "data": {"conversationId": ...}}, but handleRealtimeWebsocketEvent() only reads payload.data.notifType and payload.data.data.conversationId in TaskManager.ts. With the current fixture shape, the handler exits early and the buffering assertions are not validating real behavior (and the final-emission test fails for the wrong reason). Please build the fixture with the nested data.notifType/data.data.conversationId structure so the test covers the intended path.
Useful? React with 👍 / 👎.
| export type HistoricTranscriptsResponse = { | ||
| orgId: string; | ||
| agentId: string; | ||
| conversationId: string | null; | ||
| interactionId: string; | ||
| source: string; | ||
| data: TranscriptMessage[]; |
There was a problem hiding this comment.
Preserve historic transcript metadata in public response type
This narrows HistoricTranscriptsResponse to only agentId and data, dropping orgId, conversationId, interactionId, and source from the public API type. fetchHistoricTranscripts() still returns the backend payload as-is, so TypeScript consumers that legitimately read those fields now fail to compile even though runtime data can still include them, making this a backward-incompatible type regression. Keep the removed fields (at least optional) to avoid breaking existing integrations.
Useful? React with 👍 / 👎.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
COMPLETES
This pull request addresses
by making the following changes
Change Type
The following scenarios were tested
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.