Skip to content

ad hoc fix#4865

Open
Kesari3008 wants to merge 2 commits intowebex:nextfrom
Kesari3008:ad-hoc-fix
Open

ad hoc fix#4865
Kesari3008 wants to merge 2 commits intowebex:nextfrom
Kesari3008:ad-hoc-fix

Conversation

@Kesari3008
Copy link
Copy Markdown
Contributor

COMPLETES

This pull request addresses

by making the following changes

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@Kesari3008 Kesari3008 requested a review from a team as a code owner April 15, 2026 12:24
@Kesari3008 Kesari3008 added the validated If the pull request is validated for automation. label Apr 15, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 792a7a468a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +248 to +251
notifType: CC_EVENTS.REAL_TIME_TRANSCRIPTION,
data: {
conversationId: taskId,
messageId: 'msg-merge-1',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use RTD payload shape that TaskManager actually parses

These new RTD transcript tests construct events as {"notifType": ..., "data": {"conversationId": ...}}, but handleRealtimeWebsocketEvent() only reads payload.data.notifType and payload.data.data.conversationId in TaskManager.ts. With the current fixture shape, the handler exits early and the buffering assertions are not validating real behavior (and the final-emission test fails for the wrong reason). Please build the fixture with the nested data.notifType/data.data.conversationId structure so the test covers the intended path.

Useful? React with 👍 / 👎.

Comment on lines 857 to 859
export type HistoricTranscriptsResponse = {
orgId: string;
agentId: string;
conversationId: string | null;
interactionId: string;
source: string;
data: TranscriptMessage[];
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve historic transcript metadata in public response type

This narrows HistoricTranscriptsResponse to only agentId and data, dropping orgId, conversationId, interactionId, and source from the public API type. fetchHistoricTranscripts() still returns the backend payload as-is, so TypeScript consumers that legitimately read those fields now fail to compile even though runtime data can still include them, making this a backward-incompatible type regression. Keep the removed fields (at least optional) to avoid breaking existing integrations.

Useful? React with 👍 / 👎.

@aws-amplify-us-east-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4865.d3m3l2kee0btzx.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant