Skip to content

fix: missing webinar title in OBTP list if another device start webinar#4868

Draft
WeijuanShao wants to merge 2 commits intowebex:nextfrom
WeijuanShao:fix/obtp-no-meetingTitle
Draft

fix: missing webinar title in OBTP list if another device start webinar#4868
WeijuanShao wants to merge 2 commits intowebex:nextfrom
WeijuanShao:fix/obtp-no-meetingTitle

Conversation

@WeijuanShao
Copy link
Copy Markdown
Contributor

COMPLETES #< https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-799460 >

This pull request addresses

For this case, we may receive a message that only contains self in state_message and is missing the required info object. And in creating meeting logic will call the meetingInfo request. We won’t get the correct URI if no info object, which causes the request to fail.

Also, when creating a meeting object, it assumes a full locus and initializes certain properties (such as destination) based on it, and these properties won’t be updated later.

In this PR, the change ensures that if the locus is missing info, we first create a temporary hashTreeParser to construct a complete locus with all necessary data, and then proceed to create the meeting.

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@aws-amplify-us-east-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4868.d3m3l2kee0btzx.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant