fix(calling): read and use mobius-ws setting from wdm#4871
fix(calling): read and use mobius-ws setting from wdm#4871mkesavan13 merged 3 commits intowebex:mobius-socketfrom
Conversation
| * Reads WDM `webex.internal.device.settings['webrtc-calling-over-ws'].value`; must be | ||
| * strictly `true` to enable WebSocket—otherwise use HTTP. | ||
| */ | ||
| export function isWsFeatureEnabled(webex: WebexSDK): boolean { |
There was a problem hiding this comment.
May be a better naming is needed here. Suggestions are welcome
There was a problem hiding this comment.
isMobiusWssFeatureEnabled or isMobiusWssFeatEnabled ?
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39b8c8c02b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| this.isMobiusSocketEnabled = | ||
| isWsFeatureEnabled(config.webex) || (config.isMobiusSocketEnabled ?? false); |
There was a problem hiding this comment.
Preserve SDK WebSocket override in APIRequest init
This constructor now relies on config.isMobiusSocketEnabled for the interim opt-in path, but production call sites still create the singleton with {webex} only (for example in CallingClient, registration/register.ts, and calling/call.ts), so the override is effectively dropped unless WDM already returns true. In the rollout scenario where WDM is still false and CallingClientConfig.isMobiusSocketEnabled is set to true, APIRequest will incorrectly route requests over HTTP, breaking the intended fallback behavior described in this change.
Useful? React with 👍 / 👎.
COMPLETES CAI-7723
This pull request addresses
Reading and using the feature flag from Settings Service instead of SDK configuration to choose either HTTP requests or Mobius Requests
by making the following changes
isWsFeatureEnabledCallingClient.tsPending Items
Change Type
The following scenarios were tested
webex.internal.device.settingsThe GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.