fix(meetings): parsing Locus response in more calls to Locus APIs#4872
Open
marcin-bazyl wants to merge 1 commit intowebex:nextfrom
Open
fix(meetings): parsing Locus response in more calls to Locus APIs#4872marcin-bazyl wants to merge 1 commit intowebex:nextfrom
marcin-bazyl wants to merge 1 commit intowebex:nextfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c1666b528
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
1c1666b to
23f178e
Compare
23f178e to
3f64b37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES #SPARK-791327
This pull request addresses
Sometimes Locus API responses contain body that has a property "locus" which contains the Locus DTO and sometimes the body itself is the Locus DTO. We have a util function updateLocusFromApiResponse() that's supposed to handle any Locus DTO in API responses but it was only handling the case if body has the "locus" prop, not when body is the Locus DTO.
by making the following changes
Fixed updateLocusFromApiResponse() to handle both formats of Locus API responses. While testing I've realised that "mute all" response still doesn't get handled - it was because it's handled by ControlsOptionsManager and that class was not using the right method to invoke Locus APIs, so responses were not parsed. After that I asked AI to find other places that call Locus APIs and don't pass the responses to LocusInfo - it found a few more places.
Change Type
The following scenarios were tested
unit tests
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.