Skip to content

fix(meetings): parsing Locus response in more calls to Locus APIs#4872

Open
marcin-bazyl wants to merge 1 commit intowebex:nextfrom
marcin-bazyl:spark-791327
Open

fix(meetings): parsing Locus response in more calls to Locus APIs#4872
marcin-bazyl wants to merge 1 commit intowebex:nextfrom
marcin-bazyl:spark-791327

Conversation

@marcin-bazyl
Copy link
Copy Markdown
Collaborator

COMPLETES #SPARK-791327

This pull request addresses

Sometimes Locus API responses contain body that has a property "locus" which contains the Locus DTO and sometimes the body itself is the Locus DTO. We have a util function updateLocusFromApiResponse() that's supposed to handle any Locus DTO in API responses but it was only handling the case if body has the "locus" prop, not when body is the Locus DTO.

by making the following changes

Fixed updateLocusFromApiResponse() to handle both formats of Locus API responses. While testing I've realised that "mute all" response still doesn't get handled - it was because it's handled by ControlsOptionsManager and that class was not using the right method to invoke Locus APIs, so responses were not parsed. After that I asked AI to find other places that call Locus APIs and don't pass the responses to LocusInfo - it found a few more places.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

unit tests

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@marcin-bazyl marcin-bazyl requested review from a team as code owners April 17, 2026 09:55
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c1666b528

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/@webex/plugin-meetings/src/locus-info/index.ts Outdated
Comment thread packages/@webex/plugin-meetings/src/hashTree/hashTreeParser.ts Outdated
@aws-amplify-us-east-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4872.d3m3l2kee0btzx.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant