feat(calling): CAI 7842 event listener setup by Kesari3008 · Pull Request #4876 · webex/webex-js-sdk

Kesari3008 · 2026-04-19T22:10:17Z

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7842

This pull request addresses

Event listener refactor for Mobius Socket

by making the following changes

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

I certified that

I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

…payload

chatgpt-codex-connector · 2026-04-19T22:16:13Z

💡 Codex Review

webex-js-sdk/packages/calling/src/CallingClient/CallingClient.ts

Line 728 in d5681cc

    
           this.sdkConnector.registerMobiusSocketListener('async_event', this.handleMobiusAsyncEvent);

Subscribe to the emitted async event name

registerMobiusSocketListener() subscribes to async_event, but the Mobius socket emits typed payloads under event:<type> (for this stream, event:async_event). That mismatch prevents handleMobiusAsyncEvent from ever running, so call lifecycle events from the socket are silently dropped when WS mode is enabled.

webex-js-sdk/packages/calling/src/CallingClient/CallingClient.ts

Lines 761 to 765 in d5681cc

    
           // TODO: Handle registration down event 
        
           // const line = Object.values(this.lineDict)[0]; 
        
           // line.registration.handleRegistrationDownEvent(event); 
        
           return;

Handle registration.down by triggering recovery

The registration.down branch currently exits with a TODO and no recovery action. When Mobius sends this event (e.g., device/session invalidated), the SDK does not reconnect or re-register, leaving the client in a stale disconnected state until external/manual recovery occurs.

webex-js-sdk/packages/calling/src/CallingClient/utils/request.ts

Lines 66 to 68 in d5681cc

    
           return this.mobiusSocket.sendWssRequest({ 
        
             type: socketType, 
        
             trackingId,

Normalize websocket replies to WebexRequestPayload shape

In WS mode, makeRequest() returns the raw sendWssRequest() envelope, but calling/registration code still consumes Webex HTTP semantics (response.body.*, e.g. call setup uses response.body.callId). Without adapting WS data into body, those paths will read undefined and break call/registration state handling.

webex-js-sdk/packages/calling/src/common/Utils.ts

Lines 222 to 223 in d5681cc

    
           // TODO (Remove this later): Hardcoding the wss urls for now with test server url 
        
           primaryWss.push('wss://mobius.aload-calling1.ciscospark.com/v1/calling/web');

Remove hardcoded aload WSS endpoint from discovery list

The discovery helper unconditionally appends a test WSS host (mobius.aload-calling1...) to primary targets. That can route production clients to a non-discovered environment (or waste/fail connection attempts) whenever this endpoint is tried, instead of strictly honoring discovery/configured service URLs.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…into CAI-7842-Event-Listener-Setup

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc76b74e5e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-20T08:15:05Z

+      file: CALLING_CLIENT_FILE,
+      method: METHODS.REGISTER_MOBIUS_SOCKET_LISTENER,
+    });
+    this.sdkConnector.registerMobiusSocketListener('async_event', this.handleMobiusAsyncEvent);


Subscribe to the correct Mobius socket event key

registerMobiusSocketListener() subscribes to "async_event", but the Mobius socket emits typed messages as "event:${envelope.type}" (see packages/@webex/internal-plugin-mobius-socket/src/mobius-socket.js, _onmessage, lines 1009-1012). In socket-enabled deployments this listener never receives async envelopes, so handleMobiusAsyncEvent() is bypassed and call/registration routing from the Mobius stream does not occur.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-20T08:15:05Z

+    if (eventType === MobiusEventType.REGISTRATION_DOWN) {
+      // TODO: Handle registration down event
+      // const line = Object.values(this.lineDict)[0];
+      // line.registration.handleRegistrationDownEvent(event);
+
+      return;


Handle registration.down instead of dropping it

The new registration.down branch exits immediately with a TODO, so the client ignores backend notifications that a device registration became inactive. In that scenario no reconnect path is triggered from this event, which can leave the line unregistered and unable to place/receive calls until some unrelated recovery flow runs.

Useful? React with 👍 / 👎.

rarajes2 · 2026-04-20T09:21:25Z

+  /**
+   * @param event - TODO.
+   * @param cb - TODO.
+   */
+  public registerMobiusSocketListener<T>(event: string, cb: (data?: T) => void): void {
+    if (!mobiusSocket) {
+      mobiusSocket = getMobiusSocketInstance(instance.getWebex());
+    }
+    mobiusSocket.on(event, (data: T) => {
+      cb(data);
+    });
+  }
+
+  /**
+   * @param event - TODO.
+   */
+  public unregisterMobiusSocketListener(event: string): void {
+    if (!mobiusSocket) {
+      mobiusSocket = getMobiusSocketInstance(instance.getWebex());
+    }
+    mobiusSocket.off(event);
+  }
 }


We don't have to make this listener available through sdkConnector. These can be utilized directly inside the CallingClient

SDKConnector we are using because we were consuming internal plugin services through it but for mobius socket we don't need this route

rarajes2 · 2026-04-20T09:26:15Z

  private listenForWsEvents() {
    this.sdkConnector.registerListener('event:mobius', async (event) => {
      this.dequeueWsEvents(event);
    });
    log.info('Successfully registered listener for Mobius events', {
      file: CALL_MANAGER_FILE,
      method: METHODS.REGISTER_SESSIONS_LISTENER,
    });
  }


We have to put this method call also behind the feature flag

This is taken care of

rarajes2 · 2026-04-20T09:27:32Z

+      file: CALLING_CLIENT_FILE,
+      method: METHODS.REGISTER_MOBIUS_SOCKET_LISTENER,
+    });
+    this.sdkConnector.registerMobiusSocketListener('async_event', this.handleMobiusAsyncEvent);


Suggested change

this.sdkConnector.registerMobiusSocketListener('async_event', this.handleMobiusAsyncEvent);

this.sdkConnector.registerMobiusSocketListener('event:async_event', this.handleMobiusAsyncEvent);

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 167cea1f6c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-20T11:07:50Z

+    if (this.isMobiusSocketEnabled) {
+      this.sdkConnector.registerListener('event:mobius', async (event) => {
+        this.dequeueWsEvents(event);


Keep Mercury call listener active when socket flag is off

listenForWsEvents() now registers event:mobius only when isMobiusSocketEnabled is true, but the default path (isWsFeatureEnabled(...) === false and no override) sets that flag to false. In that common configuration, CallManager never subscribes to event:mobius, and there is no alternate non-socket listener registration elsewhere, so inbound call setup/progress/disconnect events are never routed through dequeueWsEvents().

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a53d4ecf1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-20T11:28:51Z

+    if (!this.isMobiusSocketEnabled) {
+      this.sdkConnector.registerListener('event:mobius', async (event) => {


Preserve Mercury fallback when Mobius socket is disconnected

listenForWsEvents() now skips event:mobius subscription whenever isMobiusSocketEnabled is true, but socket setup is explicitly non-fatal (connectToMobiusSocket() logs and continues when no WSS URI is available or all connects fail). In that scenario the client has neither a live Mobius-socket stream nor a Mercury fallback, so incoming call lifecycle events are never dequeued and call state stops updating. Please keep Mercury routing enabled until a socket connection is actually established (or re-enable it on socket failure).

Useful? React with 👍 / 👎.

rarajes2

Pending comments can be taken care in later PR, we can merge the PR if feature is working partially.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebfc37af99

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-20T21:55:51Z

  if (!callManager) {
-    callManager = new CallManager(webex, indicator);
+    callManager = new CallManager(webex, indicator, isMobiusSocketEnabled);
  }


Reinitialize CallManager when socket mode changes

getCallManager() now accepts isMobiusSocketEnabled, but it only applies that flag on first construction (if (!callManager) ...). Any later createClient() call with a different socket mode reuses the stale singleton, so listener wiring can be wrong for that client (e.g., first init without socket, later init with socket can process both Mercury and socket events; first init with socket, later init without socket can miss Mercury routing). This regression is introduced by the new constructor parameter being ignored after the first call.

Useful? React with 👍 / 👎.

feat(calling): refactor event listeners for mobius socket as pee new …

d5681cc

…payload

Kesari3008 requested a review from a team as a code owner April 19, 2026 22:10

Kesari3008 added validated If the pull request is validated for automation. mobius-wss labels Apr 19, 2026

Kesari3008 changed the base branch from next to mobius-socket April 19, 2026 22:10

Kesari3008 changed the title ~~Cai 7842 event listener setup~~ feat(calling): CAI 7842 event listener setup Apr 20, 2026

Kesari3008 added 2 commits April 20, 2026 13:40

feat(calling): keeping the existing listener handling

ddc5a07

Merge branch 'mobius-socket' of https://github.com/webex/webex-js-sdk …

dc76b74

…into CAI-7842-Event-Listener-Setup

chatgpt-codex-connector bot reviewed Apr 20, 2026

View reviewed changes

rarajes2 reviewed Apr 20, 2026

View reviewed changes

feat(calling): small fixes

167cea1

chatgpt-codex-connector bot reviewed Apr 20, 2026

View reviewed changes

feat(calling): ut fix

7a53d4e

chatgpt-codex-connector bot reviewed Apr 20, 2026

View reviewed changes

rsarika approved these changes Apr 20, 2026

View reviewed changes

rarajes2 approved these changes Apr 20, 2026

View reviewed changes

Merge branch 'mobius-socket' into CAI-7842-Event-Listener-Setup

ebfc37a

chatgpt-codex-connector bot reviewed Apr 20, 2026

View reviewed changes

Kesari3008 merged commit 3ac80ee into webex:mobius-socket Apr 20, 2026
11 checks passed

	this.sdkConnector.registerMobiusSocketListener('async_event', this.handleMobiusAsyncEvent);
	this.sdkConnector.registerMobiusSocketListener('event:async_event', this.handleMobiusAsyncEvent);

		if (!this.isMobiusSocketEnabled) {
		this.sdkConnector.registerListener('event:mobius', async (event) => {

Conversation

Kesari3008 commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7842

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

I certified that

Uh oh!

chatgpt-codex-connector bot commented Apr 19, 2026

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

rarajes2 Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

rarajes2 Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Kesari3008 Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

rarajes2 Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Kesari3008 Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

rarajes2 left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Kesari3008 commented Apr 19, 2026 •

edited

Loading