fix(meetings): address version resolution by riteshfyi · Pull Request #664 · webex/widgets

riteshfyi · 2026-03-30T11:36:42Z

COMPLETES #NA

This pull request addresses

right now we have version resolution issue, due to which the meetings widget repo doesn't work in next branch.

by making the following changes

avoid hoisiting of the dependenices of the meetings widget
linked the sample app's react, react-dom,webex dependencies to the the local node_modules inside the meetings widget (refer point 1)
updated the sample meeting app's webex version from 2.60.2 to 2.60.4 .
added the @babel/plugin-transform-runtime to root package.json as a devDependencies

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

tested the meetings repo locally, will use e2e tests for the cc-widgets
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

I have not skipped any automated checks
All existing and new tests passed
I have updated the testing document
I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95549a0f65

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-30T11:42:38Z

widgets-samples/samples-meeting-app/package.json

    "react": "18.3.1",
    "react-dom": "18.3.1",
-    "webex": "2.60.2"
+    "webex": "2.60.4"


Keep sample Webex version compatible with widget peer

Updating the sample app to webex: 2.60.4 makes it incompatible with @webex/widgets' declared peer requirement (webex: 2.60.2 in packages/@webex/widgets/package.json), so installs now produce a peer-dependency conflict and can fail in strict-peer environments. This undercuts the stated goal of stabilizing dependency resolution; either the sample should stay on 2.60.2 or the widget peer range should be updated to include 2.60.4.

Useful? React with 👍 / 👎.

crucial for the fix

aws-amplify-us-east-2 · 2026-03-30T11:43:02Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-664.d1b38q61t1z947.amplifyapp.com

riteshfyi · 2026-03-30T14:07:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7baa039c62

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-30T14:14:10Z

widgets-samples/samples-meeting-app/webpack.config.js

+        react: path.dirname(require.resolve('react/package.json')),
+        'react-dom': path.dirname(require.resolve('react-dom/package.json')),
+        'prop-types': path.dirname(require.resolve('prop-types/package.json')),
+        webex: path.resolve(path.dirname(require.resolve('webex')), '..'),


Resolve Webex alias from widgets workspace

This alias is resolved from samples-meeting-app and therefore does not point to packages/@webex/widgets/node_modules; Node resolution from this file only walks the sample app’s ancestor directories. In environments with multiple hoisted versions, the sample can still bind to a different webex copy than @webex/widgets, which reintroduces the version-skew problem this patch is trying to fix.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-30T14:14:10Z

widgets-samples/samples-meeting-app/webpack.config.js

+        'react-dom': path.dirname(require.resolve('react-dom/package.json')),
+        'prop-types': path.dirname(require.resolve('prop-types/package.json')),
+        webex: path.resolve(path.dirname(require.resolve('webex')), '..'),
+        '@webex/common': path.dirname(require.resolve('@webex/common/package.json')),


Avoid resolving transitive @webex/common at startup

Evaluating this require.resolve('@webex/common/package.json') at config-load time assumes @webex/common is hoisted to a location visible from the sample app. If hoisting changes (for example due to installConfig.hoistingLimits or version conflicts), @webex/common can remain nested under webex and webpack fails before compilation starts. This should be made independent of hoisting (or declared as a direct dependency).

Useful? React with 👍 / 👎.

pointed the hoisting to a fix location

Shreyas281299

Looks good. Lets just ensure the test failures are expected.

riteshfyi · 2026-04-03T10:32:04Z

The Test are passing, it's multi-login issue, which is causing the failures.

rarajes2

Just one comment

rarajes2 · 2026-04-08T03:04:38Z

package.json

    "@semantic-release/git": "^10.0.1",
    "@semantic-release/github": "^11.0.1",
    "@testing-library/react-hooks": "^8.0.1",
+    "@types/babel__plugin-transform-runtime": "^7",


Suggested change

"@types/babel__plugin-transform-runtime": "^7",

"@types/babel__plugin-transform-runtime": "^7.9.5",

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4eb029822b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-08T03:28:04Z

widgets-samples/samples-meeting-app/webpack.config.js

+        'react-dom': path.dirname(require.resolve('react-dom/package.json', { paths: [widgetsDir] })),
+        'prop-types': path.dirname(require.resolve('prop-types/package.json', { paths: [widgetsDir] })),
+        webex: path.dirname(require.resolve('webex/package', { paths: [widgetsDir] })),
+        '@webex/common': path.dirname(require.resolve('@webex/common/package.json', { paths: [widgetsDir] })),


Resolve @webex/common via webex path, not widgets root

This alias resolution can fail before webpack starts because @webex/common is a transitive dependency of webex, not a direct dependency of @webex/widgets. With the same Yarn 4 node-modules setup used here and installConfig.hoistingLimits: "dependencies" in packages/@webex/widgets/package.json, transitive packages are nested under the direct dependency (for example under webex/node_modules), so resolving @webex/common from widgetsDir throws MODULE_NOT_FOUND in environments that don’t hoist it to the widgets root.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 94427402f0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-08T03:50:41Z

widgets-samples/samples-meeting-app/webpack.config.js

+        react: path.dirname(require.resolve('react/package.json', { paths: [widgetsDir] })),
+        'react-dom': path.dirname(require.resolve('react-dom/package.json', { paths: [widgetsDir] })),
+        'prop-types': path.dirname(require.resolve('prop-types/package.json', { paths: [widgetsDir] })),
+        webex: path.dirname(require.resolve('webex/package', { paths: [widgetsDir] })),


Resolve webex alias using package.json path

Update the webex alias target to resolve webex/package.json (or the package root) instead of webex/package. As written, config evaluation can throw MODULE_NOT_FOUND before webpack starts because webex/package is not a standard resolvable subpath, which breaks both build:src and serve for the sample app when this config is loaded.

Useful? React with 👍 / 👎.

file has package only

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a67396210c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-08T04:06:00Z

widgets-samples/samples-meeting-app/webpack.config.js

+        'react-dom': path.dirname(require.resolve('react-dom/package.json', { paths: [widgetsDir] })),
+        'prop-types': path.dirname(require.resolve('prop-types/package.json', { paths: [widgetsDir] })),
+        webex: path.dirname(require.resolve('webex/package', { paths: [widgetsDir] })),
+        '@webex/common': path.dirname(require.resolve('@webex/common/package.json', { paths: [widgetsDir] })),


Resolve @webex/common from webex's dependency tree

This alias can crash webpack config loading with MODULE_NOT_FOUND under the hoisting strategy introduced in the same commit: packages/@webex/widgets/package.json now sets installConfig.hoistingLimits to dependencies, which keeps transitive deps (like @webex/common) under their direct dependency (webex) instead of widgetsDir/node_modules. Resolving @webex/common/package.json from widgetsDir therefore becomes unreliable and can fail before compilation starts in Yarn 4 node-modules installs.

Useful? React with 👍 / 👎.

if we hosit, it will again break.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08e599f9c9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-08T04:12:50Z

widgets-samples/samples-meeting-app/package.json

    "@webex/widgets": "workspace:*",
    "prop-types": "^15.7.2",
    "react": "18.3.1",
-    "react-dom": "18.3.1",
-    "webex": "2.60.2"
+    "react-dom": "18.3.1"


Re-add Webex as a direct dependency in sample app

Removing webex from this dependency block leaves @webex/widgets' webex peer unsatisfied for samples-meeting-app. That still works in lenient installs, but strict-peer environments (for example CI using strict peer checks) will fail dependency resolution before the sample can build or run. Keeping webex: 2.60.4 explicitly in the sample dependencies avoids those install-time failures and keeps the sample self-contained.

Useful? React with 👍 / 👎.

CI is passing, deps files are there

riteshfyi added 3 commits March 30, 2026 16:39

fix(meetings): address version conflict

5a7248f

fix(meetings): move devDependency to root

95549a0

fix(meetings): remove multiple versions

4a13143

riteshfyi requested a review from a team as a code owner March 30, 2026 11:36

riteshfyi added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Mar 30, 2026

chatgpt-codex-connector bot reviewed Mar 30, 2026

View reviewed changes

fix(meetings): mention missing devdependency

7baa039

chatgpt-codex-connector bot reviewed Mar 30, 2026

View reviewed changes

Shreyas281299 approved these changes Apr 1, 2026

View reviewed changes

riteshfyi and others added 7 commits April 6, 2026 08:57

fix(meetings): update peer-depedency version

b875ed5

fix(meetings): resolve deps

49c33c6

fix(meetings): remove sample app dep

e7d35cd

Merge remote-tracking branch 'origin/mw' into mw

71ceac7

Merge branch 'next' into mw

4545cee

fix(meetingss): update deps order

0ba2829

Merge remote-tracking branch 'origin/mw' into mw

9faadaf

rarajes2 approved these changes Apr 8, 2026

View reviewed changes

riteshfyi added 2 commits April 8, 2026 08:42

fix(meetings): update dep version

022b815

fix(meetings): remove extra resolutions

4eb0298

chatgpt-codex-connector bot reviewed Apr 8, 2026

View reviewed changes

fix(meetings): resolve momentum

9442740

chatgpt-codex-connector bot reviewed Apr 8, 2026

View reviewed changes

riteshfyi added 2 commits April 8, 2026 09:27

fix(meetings): final fix

a673962

fix(meetings): another fix

08e599f

chatgpt-codex-connector bot reviewed Apr 8, 2026

View reviewed changes

fix(meetings): unfix meetings

94fd528

	"@types/babel__plugin-transform-runtime": "^7",
	"@types/babel__plugin-transform-runtime": "^7.9.5",

Conversation

riteshfyi commented Mar 30, 2026

COMPLETES #NA

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

aws-amplify-us-east-2 bot commented Mar 30, 2026

Uh oh!

riteshfyi commented Mar 30, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Shreyas281299 left a comment

Choose a reason for hiding this comment

Uh oh!

riteshfyi commented Apr 3, 2026

Uh oh!

rarajes2 left a comment

Choose a reason for hiding this comment

Uh oh!

rarajes2 Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi Apr 8, 2026

riteshfyi Apr 6, 2026 •

edited

Loading