This repository was archived by the owner on Dec 17, 2021. It is now read-only.
Add simple support for new block editor#113
Open
grappler wants to merge 1 commit intowecobble:masterfrom
Open
Conversation
This is a temporary solution so that the Subtitles can still be edited in the new block editor(Gutenberg). Don’t load styles & scripts on post types that do not support subtitles. Related to wecobble#104
|
Hello, Is it possible to use that branch in a production environment ? How ? Thank you |
Author
|
Yes, you can download that version from here: https://github.com/wearerequired/Subtitles/tree/temp-gutenberg-support |
|
Great, thanks for the tip :) (and the PR !) |
|
It works perfectly fine :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a temporary solution so that the Subtitles can still be edited in the new block editor(Gutenberg).
Don’t load styles & scripts on post types that do not support subtitles.
Related to #104
How Has This Been Tested?
I have tested this on WP 5.1.1 with Gutenberg enabled for posts, a CPT with Subtitles support but in the classic editor and a CPT without Subtitles support.
Screenshots (if applicable):
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: