Conversation
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
oschijns
reviewed
Mar 20, 2026
| @@ -118,11 +118,16 @@ impl Speed { | |||
|
|
|||
| /// Getter of the duration time it must wait since the last event to target the given TPS (Transaction Per Seconds) rate | |||
| /// Consider an overhead to get a lasy duration to not overwhelmed a distant | |||
Contributor
There was a problem hiding this comment.
"lazy duration"
"to not overwhelm a distant ...???"
Contributor
Author
There was a problem hiding this comment.
Yes in the parameter, you can specify an overhead to lower a bit the speed if the distant are not fully healthy.
So it's a lazy duration because the speed will not be accurate. And this is done to not impact to much the distant.
| /// Method to check if timer are still on existing items | ||
| fn timers_retain(&mut self, head: $p, id: $p) { | ||
| let tail = id + 1 % self.queue.max_capacity(); | ||
| let tail = (id + 1) % self.queue.max_capacity(); |
Contributor
There was a problem hiding this comment.
Shouldn't it be id % (max_capacity + 1) ?
Contributor
Author
There was a problem hiding this comment.
No we want to increase by 1, without get higher than max_capacity.
So it should be (id + 1) ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug reported to fix.