fix: replaced the hardcoded value with docstring#2
Open
httpsVishu wants to merge 1 commit intowunderlabs-dev:mainfrom
Open
fix: replaced the hardcoded value with docstring#2httpsVishu wants to merge 1 commit intowunderlabs-dev:mainfrom
httpsVishu wants to merge 1 commit intowunderlabs-dev:mainfrom
Conversation
Contributor
|
@httpsVishu thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
while exploring the codebase, i found in
src/tools/share.ts, in the error message, there is a hardcoded value for 50 MBactual limit is defined using the constant
MAX_SESSION_SIZE_BYTESinconstants.ts, if this constant is changed in future, the error message would become inconsistent. so it is better to be corrected now.what i added:
Type of Change
Testing
testing was done locally by running the typescript type check and built process to ensure the change compiles correctly
commands used:
npm run type-checkandnpm run buildno errors were encountered
Checklist