update .toml #7
Open
update .toml #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update wavedash.toml config format: - org_slug → org - game_slug → game - branch_slug → environment (enum: production, demo, sandbox) Also update: - API endpoint URLs to use /environments/ instead of /branches/ - URL param from gbrslug to genv New config format: ```toml org = "my-org" game = "my-game" environment = "production" upload_dir = "./builds/webgl" ``` Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
- Warn users when org_slug, game_slug, or branch_slug are used - Guide users to use new field names: org, game, environment Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
- Add `version` field to wavedash.toml for semantic versioning (major.minor.patch) - Validate version format with regex - Send build version to API when pushing builds - Rename version() to engine_version() for clarity - Add get_build_version() method - Remove legacy field aliases (org_slug, game_slug, branch_slug) - Remove deprecated field warnings - Add regex dependency Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
cloud9c
changed the title
cloud9c
changed the title
The `version` field in wavedash.toml is now required instead of optional. This ensures all builds have a semantic version that can be matched to releases in the developer portal. - Change `build_version` from `Option<String>` to `String` - Always include version in API request body - Update getter to return `&str` instead of `Option<&str>` Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add support for passing a build message when pushing builds, similar to git commit -m. The message is stored with the build and can be displayed in the developer portal. Usage: wvdsh build push -m "Fixed player collision bug" Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
org_slug→orggame_slug→gamebranch_slug→environment(enum:production,demo,sandbox)versionfield for semantic versioning (major.minor.patch)/branches/{branch_slug}/to/environments/{environment}/New config format
Changes
versionfield with regex validation (must bemajor.minor.patch)version()toengine_version()for clarityget_build_version()methodorg_slug,game_slug,branch_slug)regexdependency for version validationTest plan
cargo checkpasseswvdsh build pushwith new config formatNote: Requires corresponding backend changes (wavedash PR #346)
🤖 Generated with Claude Code