Skip to content

Eliminate multiple connection leaks#1021

Closed
kvch wants to merge 1 commit intoxataio:mainfrom
kvch:fix-get-row-count-leak
Closed

Eliminate multiple connection leaks#1021
kvch wants to merge 1 commit intoxataio:mainfrom
kvch:fix-get-row-count-leak

Conversation

@kvch
Copy link
Copy Markdown
Contributor

@kvch kvch commented Feb 16, 2026

This PR eliminates multiple connections leaks during migrate:

  1. 2 leaked connections every time we backfilled a table
  2. 1 leaked connection when checking if an index was valid
  3. 1 leaked connection when looking up schema history

Closes #1020

@kvch
Fix multiple conenction leaks
3603f70 
* getting row count during backfill
* getting schema info
* getting history

Closes xataio#1020
@github-actions github-actions bot temporarily deployed to Docs Preview February 16, 2026 15:22 Inactive
kvch
kvch commented Feb 16, 2026
View reviewed changes
pkg/backfill/export_test.go

package backfill

var GetRowCount = getRowCount
Copy link
Copy Markdown
Contributor Author

@kvch kvch Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exported so we can use it in the test.

@kvch kvch closed this Feb 16, 2026
@github-actions github-actions bot temporarily deployed to Docs Preview February 16, 2026 15:30 Inactive
@kvch
Copy link
Copy Markdown
Contributor Author

kvch commented Feb 16, 2026

Reopened the PR from this repo, so coverage check can pass: #1022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

migrate commands holds multiple connections

1 participant

@kvch