Fix layer count in autoencoder detector#516
Open
summeraz wants to merge 1 commit intoyzhao062:developmentfrom
Open
Fix layer count in autoencoder detector#516summeraz wants to merge 1 commit intoyzhao062:developmentfrom
summeraz wants to merge 1 commit intoyzhao062:developmentfrom
Conversation
Author
|
Hey @yzhao062, sorry for jumping in unannounced with this. I have been using the |
Owner
|
sorry for being late on this~ I was in moving from my PhD to new faculty job and was totally losing track on this. Could you resubmit this PR to the development branch? I am not back to this! |
Author
|
No problem. I've changed the base branch to the development branch. I don't see any automatic CI test runs, so I'll close and reopen to see if that triggers them. Edit: No 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #138
Resolves #146
Resolves #254
This PR fixes a problem with the number of layers in the
AutoEncoderdetector. In the currentmaster, the input layer is duplicated due to a bug in the loop where the hidden layers are added. The issue is fixed here. I have also added a test to ensure that the number of layers matches expectations.All Submissions Basics:
All Submissions Cores: