This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Failing test on indentation correction#83
Open
Saeven wants to merge 1 commit intozendframework:masterfrom
Saeven:master
Open
Failing test on indentation correction#83Saeven wants to merge 1 commit intozendframework:masterfrom Saeven:master
Saeven wants to merge 1 commit intozendframework:masterfrom
Saeven:master
Conversation
Closed
Ocramius
suggested changes
Jul 23, 2017
|
|
||
|
|
||
| $testMethod = '/** @return bool */ public function someMethod() { return false; }'; | ||
| $clearedMethod = $method->invokeArgs( null, ['\t\t' . $testMethod]); |
Member
There was a problem hiding this comment.
This test uses protected API calls to trigger the failure. I can't do much with this - can you write one that uses the public API?
Member
|
This repository has been closed and moved to laminas/laminas-code; a new issue has been opened at laminas/laminas-code#20. |
Member
|
This repository has been moved to laminas/laminas-code. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested here:
#82 (comment)
@Ocramius
Used reflection since the method is protected.