feat(vectorchord) : Support lists, probes parameter list type#765
Open
R3gardless wants to merge 3 commits intozilliztech:mainfrom
Open
feat(vectorchord) : Support lists, probes parameter list type#765R3gardless wants to merge 3 commits intozilliztech:mainfrom
R3gardless wants to merge 3 commits intozilliztech:mainfrom
Conversation
- Updated the `lists` and `probes` parameters to accept comma-separated integers for more flexibility. - Added a helper function `_parse_int_list` to handle input parsing and validation. 🛠️
…probes 🎉✨ Changed 'lists' and 'probes' from single integers to lists of integers for better flexibility in configuration. This allows for multi-level IVF setups and multiple probes per IVF level. 🚀
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: R3gardless The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Updated the error handling in the _parse_int_list function to provide a clearer message when invalid input is given. This enhances user experience by making it easier to understand input requirements. 📜
Contributor
Author
|
/assign @XuanYang-cn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to official docs, vectorchord supports lists type to list, probes parameters.