Conversation
I guess the default sorting is newest first, and a new set was added, messing up the test Now it should be more robust to updates
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 94.26% 94.27%
=======================================
Files 15 15
Lines 1745 1747 +2
=======================================
+ Hits 1645 1647 +2
Misses 100 100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Norbeck ABC tune archive URL to the latest version (2026-01) and makes several changes to accommodate updates to Bill Black's Irish Traditional Tune Library, which has migrated to HTTPS and temporarily changed some files to RTF format.
Changes:
- Updated Norbeck zip archive URL from hn202110.zip to hn202601.zip
- Migrated all Bill Black URLs from HTTP to HTTPS
- Added support for RTF file format for Bill Black's s-tunes-2 file with appropriate processing logic
- Updated Bill Black tunefolder subfolder structures, particularly for O'Farrell's Pocket Companion collection
- Added xfail markers to tests for Bill Black features that are currently in flux
- Enhanced test_the_session_get_member_sets_multipage with orderby parameter and more specific assertions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_sources.py | Updated expected Norbeck tune count, added xfail markers for Bill Black tests in flux, updated regex to match RTF files, and enhanced the_session test with ordering and additional assertions |
| pyabc2/sources/norbeck.py | Updated download URL to latest Norbeck archive version (2026-01) |
| pyabc2/sources/bill_black_tunefolders.py | Migrated all URLs from HTTP to HTTPS, updated subfolder structures for various collections, reformatted subfolder lists for better readability |
| pyabc2/sources/bill_black.py | Migrated URLs to HTTPS, changed s-tunes-2 from .txt to .rtf format, added RTF processing logic to strip trailing backslashes and closing braces |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
in RTD, Norbeck zip is now failing to download
though it worked 10 min ago |
the note counts (using pandas and the note regex) computation is taking much longer (~ 7x) than it did in the v0.1.0 release
This reverts commit 3fe1c5b.
Uh oh!
There was an error while loading. Please reload this page.