fix: lazy-loaded plugins not fully activating#8
Merged
Conversation
Three issues preventing lazy plugins from working correctly:
1. Event trigger not re-firing: the event handler loaded plugins but
didn't re-fire the triggering event (e.g. InsertEnter), so plugins
like nvim-cmp loaded but never activated. The ft handler already
did this correctly.
2. packadd not sourcing after/plugin/ files: when vim.pack.add()
pre-registers plugins on the rtp, subsequent packadd calls skip
sourcing plugin/ and after/plugin/ files. This broke plugins like
cmp-buffer that register via after/plugin/ scripts. Added explicit
source_plugin_files() to handle this for both lazy and startup paths.
3. Single dependency specs silently losing fields: normalize_dependencies
treated { "user/repo", opts = {} } as a string list, dropping hash
keys like opts, init, config via ipairs. Fixed is_single_spec to
detect non-integer keys, so single specs with options are preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three issues preventing lazy plugins from working correctly:
Event trigger not re-firing: the event handler loaded plugins but didn't re-fire the triggering event (e.g. InsertEnter), so plugins like nvim-cmp loaded but never activated. The ft handler already did this correctly.
packadd not sourcing after/plugin/ files: when vim.pack.add() pre-registers plugins on the rtp, subsequent packadd calls skip sourcing plugin/ and after/plugin/ files. This broke plugins like cmp-buffer that register via after/plugin/ scripts. Added explicit source_plugin_files() to handle this for both lazy and startup paths.
Single dependency specs silently losing fields: normalize_dependencies treated { "user/repo", opts = {} } as a string list, dropping hash keys like opts, init, config via ipairs. Fixed is_single_spec to detect non-integer keys, so single specs with options are preserved.
Addresses #7