-
-
Notifications
You must be signed in to change notification settings - Fork 419
London | 26-ITP-Jan | Zadri Abdule | Sprint 2 | Form Control #1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cjyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is free of syntax error and well formatted. Well done!
- Currently, a user can still submit the form without filling in all input. Can you address this issue?
Updated the name input field to enforce a pattern that disallows only spaces.
Note: I just noticed this PR does not yet have a "Needs Review" label. Appologise if I reviewed your change prematurely. |
Updated input field for full name to require a minimum length of 2 characters.
|
The spec mentions, "All fields are required", but the current implementation does not yet fulfill this requirement. |
Updated radio button inputs to be required for color selection.
cjyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Well done!
| <input type="radio" name="color" value="blue" required> | ||
| Blue | ||
| </label> | ||
|
|
||
|
|
||
| <label> | ||
| <input type="radio" name="color" value="green"> | ||
| <input type="radio" name="color" value="green" required> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Since these radio buttons belong to the same button group, multiple required is not necessary.

Learners, PR Template
Self checklist
Changelist
Added required input fields for name and email with validation
Added T-shirt colour radio buttons
Added size dropdown menu
Fixed HTML validator