generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 418
London | 26-ITP-Jan | Zadri Abdule | Sprint 2 | Form Control #1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zadri415
wants to merge
12
commits into
CodeYourFuture:main
Choose a base branch
from
Zadri415:feature/form-controls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9b1da51
Add intitial form layout with name and email inputs
Zadri415 05ed32d
Add name and email inputs with validation rules
Zadri415 58a44cf
Add color selection with 3 radio buttons
Zadri415 9cfc9ff
Add Size selection with 6 dropdown options
Zadri415 c6b59c1
Verify 100 Lighthouse accessibility score
Zadri415 2ba6397
Finalise form markup and validation
Zadri415 b12586e
Merge branch 'CodeYourFuture:main' into feature/form-controls
Zadri415 2c6f68f
Merge branch 'main' into feature/form-controls
Zadri415 61df7d8
Add pattern validation to name input field
Zadri415 b8fec85
Refactor T-shirt color radio buttons for clarity
Zadri415 dfa1c83
Require minimum length of 2 characters for name input
Zadri415 07eb50b
Make T-shirt color radio buttons required
Zadri415 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,80 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <meta charset="utf-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <meta name="description" content=""> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
|
|
||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <!-- Customer's name --> | ||
| <div> | ||
| <label for="name">Full Name:</label><br> | ||
| <input type="text" id="name" name="name" mainlength="2" pattern=".*\S.*" title="Name must be 2 characters cannot contain only spaces" required><br> | ||
| </div> | ||
|
|
||
| <!-- Email --> | ||
| <div> | ||
| <label for="email">Email Address:</label><br> | ||
| <input type="email" id="email" name="email" required autocomplete="email"><br><br> | ||
| </div> | ||
|
|
||
| <!-- T-shirt Color --> | ||
| <fieldset> | ||
| <legend>Choose a T-shirt Color:</legend> | ||
|
|
||
| <label> | ||
| <input type="radio" name="color" value="red" required> | ||
| Red | ||
| </label> | ||
|
|
||
|
|
||
| <label> | ||
| <input type="radio" name="color" value="blue" required> | ||
| Blue | ||
| </label> | ||
|
|
||
|
|
||
| <label> | ||
| <input type="radio" name="color" value="green" required> | ||
| Green | ||
| </label> | ||
|
|
||
| </fieldset> | ||
|
|
||
| <!-- Size --> | ||
| <div> | ||
| <label for="size">Select Size:</label> | ||
| <select id="size" name="size" required> | ||
| <option value="">--Select a Size--</option> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XXL">XXL</option> | ||
| </select><br><br> | ||
| </div> | ||
|
|
||
| <!-- Submit --> | ||
| <div> | ||
| <button type="submit">Submit</button> | ||
| </div> | ||
| </form> | ||
| </main> | ||
|
|
||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By HOMEWORK SOLUTION</p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Since these radio buttons belong to the same button group, multiple
requiredis not necessary.