refactor(juno): Use common interfaces in Juno#3278
Closed
MaksymMalicki wants to merge 97 commits intomaksym/rawdb-cleanfrom
Closed
refactor(juno): Use common interfaces in Juno#3278MaksymMalicki wants to merge 97 commits intomaksym/rawdb-cleanfrom
MaksymMalicki wants to merge 97 commits intomaksym/rawdb-cleanfrom
Conversation
…Eth/juno into maksym/trie-interface
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: MaksymMalicki <81577596+MaksymMalicki@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: MaksymMalicki <81577596+MaksymMalicki@users.noreply.github.com>
Signed-off-by: MaksymMalicki <81577596+MaksymMalicki@users.noreply.github.com>
…Eth/juno into maksym/trie-interface
Signed-off-by: MaksymMalicki <81577596+MaksymMalicki@users.noreply.github.com>
…Eth/juno into maksym/trie-interface
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## maksym/rawdb #3278 +/- ##
================================================
+ Coverage 76.10% 76.30% +0.19%
================================================
Files 328 327 -1
Lines 32393 32335 -58
================================================
+ Hits 24654 24673 +19
+ Misses 5957 5889 -68
+ Partials 1782 1773 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: MaksymMalicki <81577596+MaksymMalicki@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be reviewed after #3277 . It aims to:
StateandTrieinterfaces fromcommonstateandcommontriepackages tocorepackage and rename them toCommonStateandCommonTrie. This way the circular imports are omitted and there is no naming clash.CommonStateandCommonTriein Juno. Right now both old and new implementations of State and Trie use these interfaces. It is possible to utilise the new interfaces in Juno, but always feed the old implementations to them. The CMD flag, specifying which set of implementations to use will be introduced in the next PR.CompiledClassHash()andCompiledClassHashV2()methods for the newStateMockStateHistoryReaderand all its methods toMockCommonStateThe next PR to review: #3187