feature(trie): create rawDB trieDB engine#3282
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3282 +/- ##
==========================================
- Coverage 76.20% 76.17% -0.03%
==========================================
Files 338 340 +2
Lines 32575 32611 +36
==========================================
+ Hits 24823 24842 +19
- Misses 5958 5970 +12
- Partials 1794 1799 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Nov 20, 2025
rodrodros
reviewed
Nov 21, 2025
infrmtcs
reviewed
Nov 24, 2025
EgeCaner
reviewed
Nov 27, 2025
Contributor
EgeCaner
left a comment
There was a problem hiding this comment.
Looks good! Some nitpicks
373032d to
4a7808a
Compare
EgeCaner
reviewed
Nov 27, 2025
rodrodros
approved these changes
Nov 28, 2025
rodrodros
requested changes
Nov 28, 2025
Contributor
rodrodros
left a comment
There was a problem hiding this comment.
I just realized that the code has no tests. If it is something that was done before, it's ok, but we should change it starting from this PR
EgeCaner
reviewed
Nov 28, 2025
infrmtcs
reviewed
Dec 1, 2025
EgeCaner
approved these changes
Dec 1, 2025
Contributor
EgeCaner
left a comment
There was a problem hiding this comment.
Some minor comments, rest looks good to me!
infrmtcs
reviewed
Dec 1, 2025
infrmtcs
reviewed
Dec 1, 2025
infrmtcs
reviewed
Dec 1, 2025
Contributor
infrmtcs
left a comment
There was a problem hiding this comment.
I finished my first round, please ping me after you address the comments, thanks
rodrodros
reviewed
Dec 1, 2025
infrmtcs
approved these changes
Dec 2, 2025
225d960 to
2168fca
Compare
rodrodros
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It introduces rawDB engine for the
trie2, which is used by the new state. In this PR:pathdbandhashdbboth in structure and interfaces.Contract,ClassandContract Storagesare written directly to the pebbleDB and read directly from it. The writing is done in theUpdate()method, which takes the nodesets generated bytrie2.Commit(), flattens them and writes them to the DB. For reading, thereadNode()method was introduced.rawdbas atriedbengineNext PR to review: #3283