refactor(trie2): use more descriptive felt.Address type instead of felt.Felt#3295
Merged
refactor(trie2): use more descriptive felt.Address type instead of felt.Felt#3295
felt.Address type instead of felt.Felt#3295Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3295 +/- ##
==========================================
+ Coverage 76.18% 76.24% +0.06%
==========================================
Files 340 346 +6
Lines 32611 32690 +79
==========================================
+ Hits 24845 24926 +81
- Misses 5969 5977 +8
+ Partials 1797 1787 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
373032d to
4a7808a
Compare
EgeCaner
reviewed
Nov 27, 2025
Contributor
EgeCaner
left a comment
There was a problem hiding this comment.
Looks good! Just some minor comments regarding should we do the same for Hash types. Also nitpick regarding formatting long function signatures, I prefer one parameter per line formatting for long function signatures and calls rather than
func longFunction(
param1, param2 .......
)
rodrodros
reviewed
Nov 28, 2025
225d960 to
2168fca
Compare
ee257ec to
7274438
Compare
rodrodros
approved these changes
Dec 2, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
infrmtcs
reviewed
Dec 3, 2025
EgeCaner
requested changes
Dec 3, 2025
…d of `felt.Felt`
…d of `felt.Felt`
9210f6f to
090e07a
Compare
EgeCaner
approved these changes
Dec 3, 2025
Contributor
EgeCaner
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses this comment, and uses more descriptive
felt.Addresstype for owner fields in alltriedbandtrie2packages