Fix missing contentLength in S3 driver listAll by mapping from Size#16
Open
necessarylion wants to merge 2 commits intoflydrive-js:2.xfrom
Open
Fix missing contentLength in S3 driver listAll by mapping from Size#16necessarylion wants to merge 2 commits intoflydrive-js:2.xfrom
necessarylion wants to merge 2 commits intoflydrive-js:2.xfrom
Conversation
Collaborator
|
Thanks for the PR! Could you please add a test covering this fix? We'd like to see a test that verifies contentLength is correctly populated from the Size property when using listAll. We'll review the PR once that's in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where
contentLengthwas missing in the S3 driverlistAllmethod.According to the AWS SDK documentation,
ListObjectsV2Commandreturns objects of type_Object, which do not include aContentLengthfield. Instead, the object size is provided through theSizeproperty.Because of this, the
contentLengthfield was not being populated correctly.Changes
Sizefrom theListObjectsV2Commandresponse tocontentLengthin the S3 driver#createFileMetaDatamethod.Reference
AWS SDK documentation:
https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/client/s3/command/ListObjectsV2Command/
_Objectstructure returned inContents:Size→ object size in bytesContentLengthis not included in this responseImpact
Ensures
contentLengthis correctly returned when listing objects from S3 using thelistAllmethod.