Skip to content

Fix missing contentLength in S3 driver listAll by mapping from Size #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
necessarylion wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Open

Fix missing contentLength in S3 driver listAll by mapping from Size #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
776c968
Fix missing contentLength on s3 driver listAll method
necessarylion Mar 9, 2026
6bafa75
test: verify contentLength in listAll metadata for S3 driver
necessarylion Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion drivers/s3/driver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import {
type DeleteObjectCommandInput,
type ListObjectsV2CommandInput,
type DeleteObjectsCommandInput,
type _Object,
} from '@aws-sdk/client-s3'

import debug from './debug.js'
Expand Down Expand Up @@ -82,7 +83,7 @@ export class S3Driver implements DriverContract {
#createFileMetaData(apiFile: HeadObjectOutput) {
const metaData: ObjectMetaData = {
contentType: apiFile.ContentType,
contentLength: apiFile.ContentLength!,
contentLength: apiFile.ContentLength ?? (apiFile as _Object).Size ?? 0,
etag: apiFile.ETag!,
lastModified: new Date(apiFile.LastModified!),
}
Expand Down
8 changes: 8 additions & 0 deletions tests/drivers/s3/list_all.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,14 @@ test.group('S3 Driver | listAll | root dir', (group) => {
}

const { objects } = await s3fs.listAll('/', { recursive: true })

for (const object of objects) {
if (object.isFile) {
const metadata = await object.getMetaData()
assert.equal(metadata.contentLength, 11)
}
}

assert.includeDeepMembers(Array.from(objects), [
{
isDirectory: false,
Expand Down