feat(spring): [Cache Tracing 1] Add SentryCacheWrapper and SentryCacheManagerWrapper#5172
Draft
adinauer wants to merge 5 commits intofeat/cache-tracingfrom
Draft
feat(spring): [Cache Tracing 1] Add SentryCacheWrapper and SentryCacheManagerWrapper#5172adinauer wants to merge 5 commits intofeat/cache-tracingfrom
adinauer wants to merge 5 commits intofeat/cache-tracingfrom
Conversation
…eManagerWrapper Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tion - Use cache key as span description instead of cache name, matching the spec and other SDKs (Python, JavaScript) - Skip instrumentation for putIfAbsent since we cannot know if a write actually occurred; override to bypass default get()+put() delegation - Wrap valueLoader Callable in get(key, Callable) to detect cache hit/miss instead of always reporting hit=true - Update tests to match new behavior Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- [Cache Tracing 1] Add SentryCacheWrapper and SentryCacheManagerWrapper ([#5172](https://github.com/getsentry/sentry-java/pull/5172))If none of the above apply, you can opt out of this check by adding |
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8baac33 | 313.15 ms | 367.84 ms | 54.69 ms |
| 3e5f591 | 317.48 ms | 356.80 ms | 39.32 ms |
| 2876c40 | 339.24 ms | 405.65 ms | 66.41 ms |
| 4b44539 | 255.79 ms | 300.12 ms | 44.33 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8baac33 | 0 B | 0 B | 0 B |
| 3e5f591 | 0 B | 0 B | 0 B |
| 2876c40 | 1.58 MiB | 2.29 MiB | 723.29 KiB |
| 4b44539 | 0 B | 0 B | 0 B |
Sentry Build Distribution
|
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Cache Tracing)
📜 Description
Adds
SentryCacheWrapperandSentryCacheManagerWrapperto thesentry-spring-7module. These wrapper classes instrument Spring'sCacheandCacheManagerinterfaces to producecache.get,cache.put,cache.remove, andcache.flushspans per the Sentry cache module spec.Also adds
CACHE_HIT_KEYandCACHE_KEY_KEYconstants toSpanDataConvention.💚 How did you test it?
SentryCacheWrappercovering all cache operations, hit/miss detection, error handling, and span data assertionsSentryCacheManagerWrappercovering cache wrapping, null passthrough, andgetCacheNamesdelegation📝 Checklist
sendDefaultPIIis enabled.