Skip to content

feat(core): [Cache Tracing 2] Add enableCacheTracing option#5173

Open
adinauer wants to merge 2 commits intofeat/cache-tracing-wrappersfrom
feat/cache-tracing-option
Open

feat(core): [Cache Tracing 2] Add enableCacheTracing option#5173
adinauer wants to merge 2 commits intofeat/cache-tracing-wrappersfrom
feat/cache-tracing-option

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Mar 9, 2026

PR Stack (Cache Tracing)

  • #5172 — Add SentryCacheWrapper and SentryCacheManagerWrapper
  • #5173 — Add enableCacheTracing option
  • #5174 — Add BeanPostProcessor and auto-configuration
  • #5175 — Add cache tracing e2e sample
  • #5179 — Add SentryJCacheWrapper for JCache (JSR-107)
  • #5182 — Add JCache console sample

📜 Description

Adds enableCacheTracing boolean option to SentryOptions and ExternalOptions, gating the cache wrapper span creation behind an opt-in property (sentry.enable-cache-tracing). Default is false.

💚 How did you test it?

  • SentryOptionsTest — default value, merge behavior
  • ExternalOptionsTest — property binding (true/false)
  • SentryCacheWrapperTest — no span created when option disabled

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • No breaking change or entry added to the changelog.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Spring

  • [Cache Tracing 1] Add SentryCacheWrapper and SentryCacheManagerWrapper by adinauer in #5162
  • [Cache Tracing 1] Add SentryCacheWrapper and SentryCacheManagerWrapper by adinauer in #5137

Other

  • (anr) Profile main thread when ANR and report ANR profiles to Sentry by markushi in #4899
  • (core) [Cache Tracing 2] Add enableCacheTracing option by adinauer in #5173

Bug Fixes 🐛

  • Remove the dependency on protobuf-lite for tombstones by supervacuus in #5157

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- [Cache Tracing 2] Add enableCacheTracing option ([#5173](https://github.com/getsentry/sentry-java/pull/5173))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 50c1206

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 366.46 ms 441.14 ms 74.68 ms
Size 0 B 0 B 0 B

Baseline results on branch: feat/cache-tracing-wrappers

Startup times

Revision Plain With Sentry Diff
3e5f591 317.48 ms 356.80 ms 39.32 ms
2876c40 339.24 ms 405.65 ms 66.41 ms
8baac33 313.15 ms 367.84 ms 54.69 ms
4b44539 255.79 ms 300.12 ms 44.33 ms
f94f681 405.20 ms 453.20 ms 48.00 ms

App size

Revision Plain With Sentry Diff
3e5f591 0 B 0 B 0 B
2876c40 1.58 MiB 2.29 MiB 723.29 KiB
8baac33 0 B 0 B 0 B
4b44539 0 B 0 B 0 B
f94f681 0 B 0 B 0 B

Previous results on branch: feat/cache-tracing-option

Startup times

Revision Plain With Sentry Diff
e1f4f5b 309.67 ms 365.26 ms 55.59 ms
00e75e5 309.10 ms 360.94 ms 51.84 ms
206ee68 312.72 ms 356.96 ms 44.24 ms
6dcba10 285.09 ms 372.84 ms 87.75 ms

App size

Revision Plain With Sentry Diff
e1f4f5b 0 B 0 B 0 B
00e75e5 0 B 0 B 0 B
206ee68 0 B 0 B 0 B
6dcba10 1.58 MiB 2.29 MiB 722.92 KiB

@sentry
Copy link

sentry bot commented Mar 9, 2026

Sentry Build Distribution

App Version Configuration
SDK Size 8.34.1 (1) release

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants