Open
Conversation
Branch Targeting SuggestionYou've targeted the
If This is an automated suggestion to help route contributions to the appropriate branch. |
Contributor
Review Summary by QodoAdd SOLOGOODF722 flight controller target support
WalkthroughsDescription• Add SOLOGOODF722 flight controller target with STM32F722 MCU • Configure 8 PWM outputs with timer hardware definitions • Support multiple IMU sensors (MPU6000, BMI270, ICM42605) • Enable OSD, barometer, magnetometer, and rangefinder support • Configure 6 UART ports with CRSF receiver default Diagramflowchart LR
A["SOLOGOODF722 Target"] --> B["STM32F722 MCU"]
A --> C["Timer Hardware"]
A --> D["Sensors & Peripherals"]
C --> E["8 PWM Outputs"]
D --> F["IMU: MPU6000/BMI270/ICM42605"]
D --> G["OSD, Baro, Mag, Rangefinder"]
D --> H["6 UART Ports"]
D --> I["SPI Flash & ADC"]
File Changes1. src/main/target/SOLOGOODF722/target.h
|
Contributor
Code Review by Qodo
1. Duplicate macro defines
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+161
to
+177
| #define MAX_PWM_OUTPUT_PORTS 8 | ||
| #define USE_SERIAL_4WAY_BLHELI_INTERFACE | ||
| #define USE_DSHOT | ||
| #define USE_ESC_SENSOR | ||
| #define CURRENT_METER_SCALE 250 | ||
|
|
||
| #define TARGET_IO_PORTA 0xffff | ||
| #define TARGET_IO_PORTB 0xffff | ||
| #define TARGET_IO_PORTC 0xffff | ||
| #define TARGET_IO_PORTD 0xffff | ||
| #define TARGET_IO_PORTE 0xffff | ||
| #define TARGET_IO_PORTF 0xffff | ||
|
|
||
| #define MAX_PWM_OUTPUT_PORTS 8 | ||
|
|
||
| #define USE_DSHOT | ||
| #define USE_ESC_SENSOR |
Contributor
There was a problem hiding this comment.
1. Duplicate macro defines 🐞 Bug ⛯ Reliability
target.h redefines MAX_PWM_OUTPUT_PORTS, USE_DSHOT, and USE_ESC_SENSOR. This is error-prone and can fail builds under WARNINGS_AS_ERRORS due to macro redefinition warnings.
Agent Prompt
## Issue description
`src/main/target/SOLOGOODF722/target.h` contains duplicated macro definitions (`MAX_PWM_OUTPUT_PORTS`, `USE_DSHOT`, `USE_ESC_SENSOR`). This is easy to miss during edits and may break builds when warnings are treated as errors.
## Issue Context
The file currently defines these macros twice in the same header.
## Fix Focus Areas
- src/main/target/SOLOGOODF722/target.h[161-177]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
valeriyc
force-pushed
the
sologoodf722
branch
2 times, most recently
from
eab90dd to
4f29a1c
Compare
Contributor
Review Summary by QodoAdd SOLOGOODF722 flight controller target WalkthroughsDescription• Added SOLOGOODF722 flight controller target support • Configured STM32F722 MCU with 8 motor outputs • Added support for ICM42688P gyro, DPS310 barometer, MAX7456 OSD • Registered Puya PY25Q128HA flash JEDEC ID variant Diagramflowchart LR
A["SOLOGOODF722 Target"] --> B["STM32F722 MCU"]
A --> C["8 Motor Outputs"]
A --> D["Sensors & Peripherals"]
D --> E["ICM42688P Gyro"]
D --> F["DPS310 Barometer"]
D --> G["MAX7456 OSD"]
D --> H["6 UART Ports"]
A --> I["Flash Support"]
I --> J["Puya PY25Q128HA"]
File Changes1. src/main/drivers/flash_m25p16.c
|
Contributor
Code Review by Qodo
1. Duplicate macro defines
|
Author
@qodo-code-review all findings have been fixed, please re-review |
|
Test firmware build ready — commit Download firmware for PR #11394 224 targets built. Find your board's
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added Sologood F722 target.
Added Puya PY25Q128HA flash jedecID used in SOLOGOOD F722 flight controller.
Changes
src/main/drivers/flash_m25p16.c
src/main/target/SOLOGOODF722/CMakeLists.txt
src/main/target/SOLOGOODF722/target.h
src/main/target/SOLOGOODF722/target.c
Notes
Tested UART1 (Walksnail Avatar OSD), UART2 (RX), UART6 and SPI (gps+magnitometer), S1-S6 (by spinning 4 motors, 2 servos), Gyroscope, Accelerometer, Barometer and blackbox flash.
Betaflight default CLI configuration:
Inav configurator CLI after flashing: