MCO-2171: Move long running boot image tests to MCO's disruptive suites#5808
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@djoshy: This pull request references MCO-2171 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughChanges involve consolidating boot image test infrastructure by removing three dedicated boot image test modules while redistributing core helper functions to existing test utilities and adding a randomized machine set selector. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-1of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-2of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive-techpreview-1of3 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive-techpreview-2of3 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive-techpreview-3of3 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-1of3 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-2of3 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-3of3 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of3 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-2of3 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-3of3 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview |
|
@djoshy: trigger 15 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8f143c00-2887-11f1-916b-b0c8860934dc-0 |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive |
|
@djoshy: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f1e60760-2976-11f1-88b9-e80c44c123f4-0 |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/extended/custom_pool_booting.go`:
- Around line 248-255: The getRandomMachineSet function can panic when
machineSets.Items is empty; before creating rnd.Intn(len(machineSets.Items)) add
an explicit non-empty assertion—e.g., assert len(machineSets.Items) > 0 using
the test helper (o.Expect(len(machineSets.Items)).To(o.BeNumerically(">", 0)))
or return a clear error—so the failure is deterministic and avoids Intn(0); keep
references to machineSets.Items and rnd in the same function and ensure the
assertion happens right after the List() call and before selecting
machineSetUnderTest.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a865ab56-3a11-4eff-9d71-c54b46ddf7c8
📒 Files selected for processing (7)
test/extended-priv/mco_bootimages.gotest/extended/boot_image.gotest/extended/boot_image_update_agnostic.gotest/extended/boot_image_update_azure.gotest/extended/custom_pool_booting.gotest/extended/machineconfigpool.gotest/extended/node.go
💤 Files with no reviewable changes (4)
- test/extended/node.go
- test/extended/boot_image_update_agnostic.go
- test/extended/boot_image_update_azure.go
- test/extended/boot_image.go
|
No timeouts on this run: #5808 (comment), failures are pre-existing and unrelated to this PR, so this should be good to go. |
|
/verified by payloads |
openshift-ci-robot
added
the
verified
|
@djoshy: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, sergiordlr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required this change should only affect disruptive jobs, so pretty sure these failures are unrelated, but running once again to be safe |
|
/retest |
|
@djoshy: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
- What I did
This PR moves the AWS, GCP, Azure and vsphere bootimage tests from the long running suite to the disruptive suite.
- How to verify it
Disruptive suite should continue to pass without any timeout issues.