Fix install script failing when piped in a shell#9178
Merged
begelundmuller merged 2 commits intomainfrom Apr 6, 2026
Merged
Conversation
2c7dcb2 to
2ef16a0
Compare
2ef16a0 to
e639431
Compare
begelundmuller
commented
Apr 3, 2026
Comment on lines
-49
to
-51
| sha256_verify="shasum --algorithm 256 --ignore-missing --check" | ||
| elif [ -x "$(command -v sha256sum)" ]; then | ||
| sha256_verify="sha256sum --ignore-missing --check" |
Contributor
Author
There was a problem hiding this comment.
Note: Turned this into explicit calls to avoid relying on unquoted expansion
Comment on lines
-70
to
-72
| set -- "--silent" "--show-error" | ||
| curl --location --silent --show-error "${BINARY_URL}" --output "rill_${PLATFORM}.zip" | ||
| else | ||
| set -- "--progress-bar" |
Contributor
Author
There was a problem hiding this comment.
Note: changed to explicit case handling instead of overriding args (which is fragile)
| SYFT_URL=https://event.syftdata.com/log | ||
| SYFT_ID=clp76quhs0006l908bux79l4v | ||
| if [ -z "$RILL_INSTALL_DISABLE_TELEMETRY" ]; then | ||
| curl --silent --show-error --header "Authorization: ${SYFT_ID}" --header "Content-Type: application/json" --data "{\"event_name\":\"$1\"}" $SYFT_URL > /dev/null || true >&2 |
Contributor
Author
There was a problem hiding this comment.
Note: the pipe applied to true, but should apply to curl
kaspersjo
approved these changes
Apr 6, 2026
kaspersjo
approved these changes
Apr 6, 2026
Contributor
|
LGTM! |
begelundmuller
added a commit
that referenced
this pull request
Apr 6, 2026
* Various install script fixes * Formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes one fix and two improvements to the install script:
shbasenamefailing with an unknown flag error for thePARENT_NAMEchecks; this happened because the current shell process name has a dash prefix like-zshwhen executing a pipeline/dev/ttycheck instead of checking the parent process nameI have verified the script works with
cat ./scripts/install.sh | shin the following settings:Checklist: