Skip to content

Fix console errors on CollectionObject form page #7907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
acwhite211 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix console errors on CollectionObject form page #7907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88a3ef4
Ignore legacy synthetic form fields in form parser
acwhite211 Apr 8, 2026
a012383
Fix storage tree permission registry order
acwhite211 Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions specifyweb/frontend/js_src/lib/components/FormParse/cells.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,17 @@ export type SubViewSortField = {
export const cellAlign = ['left', 'center', 'right'] as const;
export const cellVerticalAlign = ['stretch', 'center', 'start', 'end'] as const;

const specialFieldNames = new Set([
/*
* Legacy synthetic form controls that are not schema-backed fields.
* These are still parsed intentionally by some field renderers.
*/
'this',
'generateLabelChk',
'generateInvoice',
'sendEMail',
]);

const processCellType: {
readonly [KEY in keyof CellTypes]: (props: {
readonly cell: SimpleXmlNode;
Expand Down Expand Up @@ -156,6 +167,7 @@ const processCellType: {

if (
resolvedFields === undefined &&
!specialFieldNames.has(rawFieldName ?? '') &&
(fieldDefinition.type !== 'Plugin' ||
fieldDefinition.pluginDefinition.type === 'PartialDateUI')
)
Expand Down
2 changes: 1 addition & 1 deletion specifyweb/frontend/js_src/lib/components/Permissions/definitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ export const operationPolicies = {
'/tree/edit/storage': [
'merge',
'move',
'bulk_move',
'synonymize',
'desynonymize',
'repair',
'bulk_move',
],
'/tree/edit/geologictimeperiod': [
'merge',
Expand Down
Loading