Conversation
* getting row count during backfill * getting schema info * getting history Closes #1020
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
kvch
commented
Feb 16, 2026
| // In that case, we can safely return false. | ||
| return false, nil | ||
| } | ||
| defer rows.Close() |
Contributor
Author
There was a problem hiding this comment.
In this file rows.Close were missing.
kvch
commented
Feb 16, 2026
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer rows.Close() |
kvch
commented
Feb 16, 2026
| defer rows.Close() | ||
|
|
||
| if err := db.ScanFirstValue(rows, ¤tSchema); err != nil { | ||
| rows.Close() |
Contributor
Author
There was a problem hiding this comment.
rows.Close is called immediately so the connection is returned to the pool right away. All rows.Close are required because rows gets reassigned twice, and they must be returned to the pool as well to avoid leaks.
tsg
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR eliminates multiple connections leaks during
migrate:Closes #1020